Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of insert_overwrite in cluster setup #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support of insert_overwrite in cluster setup #394

wants to merge 1 commit into from

Conversation

pheepa
Copy link

@pheepa pheepa commented Nov 28, 2024

Summary

Support of insert_overwrite in cluster setup with incremental and distributed_incremental materializations

In details

  1. In case is_distributed is True it creates distributed version of new data, gets partitions from cluster(system.parts) and replace in local existing table
  2. The intermediate_relation entity was deleted as unnecessary because it is a incremental_legacy remnant.
  3. The existing test for insert_overwrite was renamed and made deterministic

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@pheepa
1) Support of insert_overwrite on cluster
94e9242 
2) Test for insert_overwrite with "incremental" and RepicatedMergeTree
3) Test for insert_overwrite with "distributed_incremental"
4) Changed naming of tests to actual
5) Refactored old test to be more determinate
@pheepa pheepa mentioned this pull request Nov 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pheepa